fix(worker): cap slskd ETA + rollback on progress-write failure (stop txn-abort job churn)
A near-stalled Soulseek peer drives the EWMA speed toward zero, so _eta_seconds returned int(remaining/speed) values far past int4 max. Writing that to Job.downloadEtaSeconds (an integer column) raised "integer out of range", which aborted the SHARED pipeline connection's transaction. The on_progress except clause logged but never rolled back, so every subsequent query cascaded "current transaction is aborted" and the whole job failed and requeued (9 such failures / 24h observed in prod). - Cap _eta_seconds at ~100h (359999s), well inside int4. - Roll back the shared conn in on_progress's except so a failed progress write can never poison the pipeline txn, honoring the existing docstring promise that "a progress write must never fail the download". - Regression test for the near-stall cap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -29,12 +29,17 @@ def _dirname(path: str) -> str:
|
||||
return ""
|
||||
|
||||
|
||||
_ETA_CAP_SECONDS = 359_999 # ~100h; keeps the value well inside Job.downloadEtaSeconds (int4)
|
||||
|
||||
|
||||
def _eta_seconds(total_bytes: int, bytes_now: int, speed_bps: float) -> int | None:
|
||||
"""Seconds until the transfer finishes at the current measured rate, or None when it can't be
|
||||
estimated (no throughput sample yet, unknown total, or already complete). Pure — unit-tested."""
|
||||
estimated (no throughput sample yet, unknown total, or already complete). Pure — unit-tested.
|
||||
A near-stalled peer drives speed_bps toward zero, so the estimate is capped: an uncapped value
|
||||
can exceed int4 and overflow the downloadEtaSeconds column write (poisoning the pipeline txn)."""
|
||||
if speed_bps <= 0 or total_bytes <= 0 or bytes_now >= total_bytes:
|
||||
return None
|
||||
return int((total_bytes - bytes_now) / speed_bps)
|
||||
return min(int((total_bytes - bytes_now) / speed_bps), _ETA_CAP_SECONDS)
|
||||
|
||||
|
||||
def _norm(s: str) -> str:
|
||||
|
||||
Reference in New Issue
Block a user