Jonathan/Lyra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(discovery): use a valid ListenBrainz similar-artists algorithm

Browse Source 
The placeholder algorithm string (contribution_5_threshold_15_limit_50) is not a
permitted enum member of the LB Labs endpoint — every lookup 400'd, making discovery
inert. Verified against the live API 2026-07-12: the days_7500/contribution_3/
threshold_10/limit_100 variant returns rows shaped {artist_mbid,name,comment,score},
which the existing defensive parser already handles. Fixed in both the worker adapter
and the web seed-search client (kept in sync).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jonathan
2026-07-12 00:54:33 +02:00
parent b9ebd18c2c
commit d2c581d8e7
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/lib/listenbrainz.ts
+3 -2
View File
@@ -1,7 +1,8 @@
const LB_BASE = process.env.LISTENBRAINZ_URL ?? "https://labs.api.listenbrainz.org"; const LB_BASE = process.env.LISTENBRAINZ_URL ?? "https://labs.api.listenbrainz.org";
// Keep in sync with the worker's _listenbrainz.py default algorithm. // Keep in sync with the worker's _listenbrainz.py default algorithm. Must be a
// permitted enum member of the LB endpoint (invalid strings 400). Verified live 2026-07-12.
const ALGORITHM = const ALGORITHM =
"session_based_days_7500_session_300_contribution_5_threshold_15_limit_50_filter_True_skip_30"; "session_based_days_7500_session_300_contribution_3_threshold_10_limit_100_filter_True_skip_30";
export type SimilarArtist = { mbid: string; name: string; score: number }; export type SimilarArtist = { mbid: string; name: string; score: number };
worker/lyra_worker/similarity/_listenbrainz.py
+5 -4
View File
@@ -3,11 +3,12 @@ import requests
from lyra_worker.similarity.base import SimilarArtist from lyra_worker.similarity.base import SimilarArtist
_DEFAULT_URL = "https://labs.api.listenbrainz.org" _DEFAULT_URL = "https://labs.api.listenbrainz.org"
# ListenBrainz Labs similar-artists dataset requires an algorithm parameter. # ListenBrainz Labs similar-artists dataset requires an algorithm parameter whose
# NOTE: confirm this string + response field names against the live API during # value must be one of the endpoint's permitted enum members (an invalid string 400s).
# manual verification; parsing below is defensive if the shape shifts. # Verified against the live API 2026-07-12: this algorithm returns rows shaped
# {artist_mbid, name, comment, score, ...}, which the parser below reads defensively.
_DEFAULT_ALGORITHM = ( _DEFAULT_ALGORITHM = (
"session_based_days_7500_session_300_contribution_5_threshold_15_limit_50_filter_True_skip_30" "session_based_days_7500_session_300_contribution_3_threshold_10_limit_100_filter_True_skip_30"
) )