Jonathan/Lyra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(worker): mark the chosen candidate at download-start, not after success

Browse Source 
_mark_chosen ran only after a download succeeded, so throughout the 'downloading'
state no candidate was chosen — the Floor row's "source · format · tracks" line was
blank (only elapsed showed). Now mark the candidate exclusively at each download
attempt so `chosen` reflects the source in flight (and updates on fall-through).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jonathan
2026-07-13 22:17:18 +02:00
parent 381426082e
commit fdca692bb5
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
worker/tests/test_pipeline.py
+14
View File
@@ -46,6 +46,20 @@ def test_falls_through_when_best_download_fails(conn):
assert cur.fetchone()[0] == "soulseek"
def test_fallthrough_marks_exactly_one_chosen(conn):
# `chosen` now marks the source in flight at each attempt; after falling through from a
# failed source to a working one, exactly ONE candidate stays chosen (the winner) — the
# attempted-then-failed source must be un-marked (exclusive _mark_chosen).
job_id = insert_request(conn, artist="Radiohead", album="In Rainbows")
claim_next(conn)
run_pipeline(conn, job_id, [FailingAdapter(), FakeSoulseek()], dest_root="/tmp/lib")
with conn.cursor() as cur:
cur.execute('SELECT count(*) FROM "Candidate" WHERE "jobId" = %s AND chosen = true', (job_id,))
assert cur.fetchone()[0] == 1
cur.execute('SELECT source FROM "Candidate" WHERE "jobId" = %s AND chosen = true', (job_id,))
assert cur.fetchone()[0] == "soulseek"
def test_no_match_goes_to_needs_attention(conn):
job_id = insert_request(conn, artist="Radiohead", album="In Rainbows")
claim_next(conn)